Increase general library quality

RobotWebTools / roslibjs

The Standard ROS JavaScript Library

https://robotwebtools.github.io/roslibjs

Other

678 stars 378 forks source link

Increase general library quality #647

Closed MatthijsBurgh closed 7 months ago

MatthijsBurgh commented 10 months ago

The robostack fork, has applied some improvements like:

Migrating to typescript
Migrating to ES6 classes
Replacing grunt by rollup

This might be good improvements to apply to the original library as well. Preferably we include these changes also in the ros3djs and ros2djs libraries.

EzraBrooks commented 10 months ago

Agreed. I would recommend we start by adding a TypeScript compiler configuration that allows JavaScript files, fixing any issues with statically type checking the current JS, then move forward with TS.

EzraBrooks commented 10 months ago

headed in that direction (adopting the typescript compiler without yet adopting typescript) in #649

EzraBrooks commented 8 months ago

Once #665 (and all the dependent PRs that have come out of it) are in, I plan on making a PR to switch from Grunt + Browserify + Karma to Vite (which includes Rollup) and Vitest, as that's what I have experience with using lately and I think Vite's "library mode" is a very sensible preset for a package like roslibjs.