search

RobotWebTools / roslibjs

The Standard ROS JavaScript Library
https://robotwebtools.github.io/roslibjs
Other
660 stars 372 forks source link

What to do with socket.io? #648

Closed MatthijsBurgh closed 6 months ago

MatthijsBurgh commented 7 months ago

We allow usage of socket.io as transport layer. Though it is not included in the library. So the user should provide it him/herself.

Though it isn't tested. So I don't know whether it works.

We should clean up this situation.

Related: https://github.com/RobotWebTools/roslibjs/pull/429

EzraBrooks commented 7 months ago

My ongoing adventures with typescript type checking seem to imply that this feature does not actually work, because the code as written doesn't compile due to a function signature mismatch

MatthijsBurgh commented 7 months ago

So I suggest to drop it.