There are a number of places where class members were being declared in the constructor and assigned to constant values that could easily be moved up into the class definition itself - when I converted everything to classes from prototypes, I just used the automatic refactor in VS Code, which wasn't smart enough to extract these. This PR moves them to the class definition and deals with the fallout of TypeScript being able to better-understand their types now.
It also goes around and removes the old that = this workaround that was popular before arrow functions allowed scope capture for callbacks and replaces those classic functions with arrow functions.
Public API Changes
hopefully none
Description
There are a number of places where class members were being declared in the constructor and assigned to constant values that could easily be moved up into the class definition itself - when I converted everything to classes from prototypes, I just used the automatic refactor in VS Code, which wasn't smart enough to extract these. This PR moves them to the class definition and deals with the fallout of TypeScript being able to better-understand their types now.
It also goes around and removes the old
that = thisworkaround that was popular before arrow functions allowed scope capture for callbacks and replaces those classic functions with arrow functions.