search

RobotWebTools / webrtc_ros

Streaming of ROS Image Topics using WebRTC
Other
131 stars 52 forks source link

Add better support for bridging webrtc logging to ROS #20

Closed mitchellwills closed 9 years ago

mitchellwills commented 9 years ago

This adds better support for bridging logging from webrtc source code to ROS. Previously only a few messages were correctly converted, but this adds support for the rest of logs produced by webrtc.

Unfortunately, in order to do this correctly we must use some internal knowledge of the rosconsole implementation (https://github.com/mitchellwills/webrtc_ros/blob/logging/webrtc_ros/src/ros_log_context.cpp#L32-L50). The current code base supports hydro, indigo, and jade.

rctoris commented 9 years ago

I think this is fine given we are only building currently on those versions!