search

RobotWebTools / webrtc_ros

Streaming of ROS Image Topics using WebRTC
Other
144 stars 57 forks source link

Arm64 support and Dockerfile twekas. #60

Closed kubja closed 3 years ago

kubja commented 3 years ago

This pull request adds support for arm64 and is an addition to work by @GMahmoud in PR #59 and Issue #58 to fix build for armhf. libjpeg-turbo8 also won't build on arm64 so I made the build use the external library for all platforms. This should be fine since libjpeg-turbo8` comes along ROS Noetic perception packages anyway.

In addition to that, the prebuilt gn binary for arm64 fails to generate build files with the M86 version. Since others were facing issues with the prebuilt binaries on other platforms, I removed the binaries and made the gn to be built from source by default. Maybe there is a bigger reason I don't see to ship binaries alongside the repo and we can revert that.

There are also some small tweaks to Dockerfile to make the final image smaller (from ~16GB to 3.3GB).

roehling commented 3 years ago

This PR is a superset of #59, right?

GMahmoud commented 3 years ago

Yes @roehling the small modification of the #59 is included in this PR. If you accept this PR the #59 could be closed