search

RobotecAI / RobotecGPULidar

Other
216 stars 17 forks source link

Feature/rework dockerfile feedback Part 2 #296

Closed ruffsl closed 3 months ago

ruffsl commented 3 months ago

I modded the CMake a little to simplify and generalize the Dockerfile, although I would be nice if something like colcon and install workspaces could be used to formalize the output paths, so paths aren't so informally relative.

I also think the multi staging logic for ROS and PCL could be generalize, perhaps using Docker bake files. But let me think about that a little more.

msz-rai commented 3 months ago

Please let me know when you finish your work. I will review your changes, merge them, and ensure our CI is functioning correctly. Once everything is set, we'll be ready to release a new version.