RobotecAI / awsim_sensor_kit_launch

AWF Autoware sensor kit for AWSIM simulator
Apache License 2.0
2 stars 23 forks source link

refactor: pointcloud_preprocessor prefix package and namespace with autoware #15

Closed amadeuszsz closed 3 months ago

amadeuszsz commented 3 months ago

Description

Part of Autoware namespace refactor.

Related links

Parent Issue:

Related PRs:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

amadeuszsz commented 3 months ago

memo: wait for autoware.universe merge first

shmpwk commented 3 months ago

@amadeuszsz @technolojin Do you think we can merge now or should we wait for https://github.com/tier4/AWSIM/pull/334 ?

amadeuszsz commented 3 months ago

@amadeuszsz @technolojin Do you think we can merge now or should we wait for tier4/AWSIM#334 ?

@shmpwk Yes. Parent PR (already merged) refers only to package's namespace. Without merging this PR, e2e_simulator.launch.xml will fail for now on main branch since pointcloud_preprocessor package does not exist with this name anymore.

shmpwk commented 3 months ago

Thank you, I'll merge this.