RobotecAI / o3de-rgl-gem

Robotec GPU Lidar for O3DE
Apache License 2.0
51 stars 4 forks source link

Require ROS 2 Gem == 2.1.0 #43

Closed jhanca-robotecai closed 3 months ago

jhanca-robotecai commented 3 months ago

Not sure if you allow pushing the code directly to main branch, but this change makes a lot of sense to me (twin PR to #42 ). If you add a gem using GUI, it will NOT be allowed. If you add it manually, you will get an error at cmake configure error instead of getting a compile error.

Tested against o3de-extras with development branch:

[build]     The following dependency requirements could not be satisfied:
[build] 
[build]   The project requires ROS2>=3.1.0
[build] 
[build]   <Gem RGL==0.0.0> requires ROS2<=3.1.0
alek-kam-robotec-ai commented 3 months ago

As this branch is intended to work with the latest point release I've changed the version.

jhanca-robotecai commented 3 months ago

As this branch is intended to work with the latest point release I've changed the version.

Which branch targets the current stabilization in O3DE? I thought this one, so I set the version accordingly.

alek-kam-robotec-ai commented 3 months ago

This branch targets the latest point release. o3de's stabilization branch is used with the development branches of both the extras and rgl gems as shown below: image