search

RobotecAI / robotec-o3de-tools

Toolset for demo recordings in O3DE
5 stars 1 forks source link

[Pointcloud] New interfaces and automatic asset reloading #49

Closed Fireronin closed 3 months ago

Fireronin commented 3 months ago

Resolves #40

Adds AcquirePointcloudFromAsset and UpdatePointCloud Interfaces to feature processor.

First one creates a ponint cloud based on asset and keeps track of it's changes. Second one allows for partial updates to pointcloud data

Fireronin commented 3 months ago

I'm unable to fix those formatting issues like I mash reformat and nothing happens, I think my formatting style is correct as I was able to fix other issues using the same formatting

michalpelka commented 3 months ago

I've fixed code with help of o3de Discord : https://discord.com/channels/805939474655346758/816043601754325023/1271239320698748951 Now hot-realoding works as expected. Our error was, that we have old and new asset. We should keep reference to AZ::Asset<AZ::Data> and we are responsible to swap this reference. Without that we are stuck with reference to old data. When reference count on old asset goes to zero, it is destroyed. It is smart, but requires understanding.

untitled.webm

With permission from @Fireronin, I've forced pushed code.

michalpelka commented 3 months ago

I've added @norbertprokopiuk @zakmat to review, since they are using this code.