search

RobotecAI / ros2-for-unity

High-performance ROS2 solution for Unity3D
Apache License 2.0
448 stars 58 forks source link

add Service and Client methods #58

Closed Deric-W closed 1 year ago

Deric-W commented 1 year ago

Hi, I added methods for using Clients and Services implemented in RobotecAI/ros2cs#36 (or RobotecAI/ros2cs#30, which would require slight modifications). This is a draft since the version in ros2cs.repos needs to be updated after one of the the mentioned pull requests has been merged.

adamdbrw commented 1 year ago

@Deric-W could this be un-drafted now?

Deric-W commented 1 year ago

I think it would be better to wait for RobotecAI/ros2cs#39 to be solved to prevent build failures.

pijaro commented 1 year ago

@Deric-W https://github.com/RobotecAI/ros2cs/issues/39 is now resolved, I've also done some quick tests on Windows and Ubuntu, and it looks like the tests are working again. Therefore, I think that we can now take the draft off 👍

Deric-W commented 1 year ago

Ok, but the ros2cs version has to be incremented to reference a commit where the issue is fixed.

pijaro commented 1 year ago

Yep, ros2cs version has been updated. Changed the target branch as well (we set develop as the default branch)

Merging, thanks!