search

RobotecAI / ros2cs

A C# (.Net) implementation of ros2 client library (rcl), enabling communication between ros2 ecosystem and C#/.Net applications such as Unity3D
Apache License 2.0
89 stars 22 forks source link

Automatic tests #48

Open Deric-W opened 1 year ago

Deric-W commented 1 year ago

Hello, since this project supports two platforms and two Ros2 Distributions I think it would be beneficial to run the tests automatically when pushing to master to prevent some combinations from being left out and decrease the amount of work required to verify contributions.

I thougt about using Github Actions for this purpose, what do you think?

Deric-W commented 1 year ago

Iam a bit confused which ROS2 distributions and platforms are supported, the Readme mentions Ubuntu and Windows with galactic and humble while there exists additional utilities for foxy, MacOSX and UWP. Where these just forgotten or is the Readme wrong?

pijaro commented 1 year ago

Automatic testing is definitely on our roadmap. We primarily wanted to pair it with Ros2ForUnity, but handling Unity appeared to be a problem in CI/CD. Therefore, the delay.

As for the support - we support Galactic/Humble on Ubuntu/Windows. However, we left the foxy and other utilities because they "should" work. We can't guarantee it, and our help can be limited, but it can be run if someone really wants to. I believe we will clean the "leftovers" with the new release.

Deric-W commented 1 year ago

Iam currently experimenting on this branch and try to get the Windows setup working. Can we ignore Unity for this repository since it is mostly independent?

pijaro commented 1 year ago

Yes, definitely, we can ignore the Unity for this repo :+1:

Deric-W commented 1 year ago

I have problems getting the Workflow to work on Windows since colcon likes to pick the wrong Python version, did you encounter such issues?