search

Robotic-Decision-Making-Lab / alpha

ROS 2 interface for the Reach Alpha 5 manipulator.
MIT License
11 stars 2 forks source link

[FEATURE]: Create logger instance in classes #35

Closed evan-palmer closed 1 year ago

evan-palmer commented 1 year ago

Feature Type

Changing existing functionality in the Alpha driver

Problem Description

The existing implementation uses a redundant approach to logging. Specifically, the current implementation makes a call to the rclcpp interface to get a logger with a given name and then to generate a log with that logger. This is redundant and difficult to maintain.

Feature Description

Create a logger class member to use. This will make it easier to manage the logging interface.

Alternative Solutions

There are projects that use the same approach to logging as that already done, so this could be left as-is.

Additional Context

No response

evan-palmer commented 1 year ago

Upon further investigation, this isn't something that can be easily done inside of the hardware interface classes. Due to the deleted constructor. Closing this for the sake of consistency across the project.