Robotic-Decision-Making-Lab / blue

ROS 2 platform for underwater robotics research and development.
https://robotic-decision-making-lab.github.io/blue/
MIT License
40 stars 9 forks source link

Resolved bug in BlueROV2 Heavy and Heavy Reach launch configurations #193

Closed evan-palmer closed 1 week ago

evan-palmer commented 1 week ago

Changes Made

This PR adds a few fixes: some of which were recognized while I was debugging the build for Humble yesterday. The changes are as follows:

  1. Fix the ardupilot_gazebo install. The dependencies have changed there and needed to be updated
  2. Stopped passing the robot description file directly to the controller manager. This has been deprecated by the ros2_control team and needed to be fixed
  3. Addressed a bad default path in the launch file for the BlueROV2 Heavy and Heavy Reach configurations

Associated Issues

Testing

Testing was performed using Iron and Humble. Jazzy and Rolling are still being upgraded, so everything is broken there right now.

evan-palmer commented 1 week ago

@mergify backport iron humble

mergify[bot] commented 1 week ago

backport iron humble

✅ Backports have been created

* [#194 Resolved bug in BlueROV2 Heavy and Heavy Reach launch configurations (backport #193)](https://github.com/Robotic-Decision-Making-Lab/blue/pull/194) has been created for branch `iron` * [#195 Resolved bug in BlueROV2 Heavy and Heavy Reach launch configurations (backport #193)](https://github.com/Robotic-Decision-Making-Lab/blue/pull/195) has been created for branch `humble`