search

RoboticExplorationLab / Altro.jl

MIT License
139 stars 41 forks source link

fix: ilqr backward pass with save_S option #9

Closed Derollez closed 2 years ago

Derollez commented 3 years ago

Fixed notations for value function derivatives .x -->.q and .xx --> .Q in backward pass.jl for function static_backwardpass! for compliance in SystemVerification.jl Need confirmation on constant term value of 'QuadraticCost' object in line 133 @bjack205 *Only fixed notations in that specific function. Some similar changes might still be needed in that script (see _bp_reg! function maybe for instance). Did not touch those ones. Need confirmation here @bjack205

codecov-io commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cc30847). Click here to learn what that means. The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   75.13%           
=========================================
  Files             ?       19           
  Lines             ?     1126           
  Branches          ?        0           
=========================================
  Hits              ?      846           
  Misses            ?      280           
  Partials          ?        0
Impacted Files Coverage Δ
src/ilqr/backwardpass.jl 80.55% <25.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc30847...a7e3795. Read the comment docs.

bjack205 commented 2 years ago

Closing this since it's being fixed by the new version #31