Final polish and first production release

RoboticSwarmControl / SwarmControlRedux

This is the Node reimplementation of the SwarmControl website.

MIT License

2 stars 1 forks source link

Final polish and first production release #44

Closed crertel closed 7 years ago

crertel commented 7 years ago

We're finally almost ready to go live!

Last couple of things to check:

Make sure that the most recent game results (for the user) are stored either in localStorage or are at least being detected properly from the returned result
Check out a report that the stars might not be updating proeprly.
Add another "Accept Terms" button to the ToS splash
Push it live.

crertel commented 7 years ago

So, investigating the stars, it looks like the robot-positiong game is fine, but the pyramid-building game seems to only display the star on the main screen, and not on the post-game wrapup.

crertel commented 7 years ago

(work is being done on branch 44-final-polish)

crertel commented 7 years ago

So, fixed the stars not showing up. It appeared to be a weird interaction between:

The way the participant string was being extracted from the cookie
A race condition where results could be fetched before the new result had been posted.

This now seems to be fixed in local testing--testing in staging next.

crertel commented 7 years ago

Confirmed fixed on staging server--with fresh cookies, all tasks register the first start correctly now. Next is going to be fixing the "latest result" bit.

crertel commented 7 years ago

Fixed the stars and results for the participant counts not lining up. Fixed now!

aabecker commented 7 years ago

Can you go live?

Aaron T. Becker

Assistant Professor of Electrical & Computer Engineering, University of Houston youtube.com/aabecker5/

On Mon, Dec 12, 2016 at 3:50 PM, crertel notifications@github.com wrote:

Fixed the stars and results for the participant counts not lining up. Fixed now!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RoboticSwarmControl/SwarmControlRedux/issues/44#issuecomment-266563887, or mute the thread https://github.com/notifications/unsubscribe-auth/AEGkJDCOxG8UidZ_KT8D8Lgd7VQT88WWks5rHcGhgaJpZM4LKvEa .

crertel commented 7 years ago

Going live once this is merged!

crertel commented 7 years ago

Fixed ToS needing second accept. Opened and merged PR #45.

crertel commented 7 years ago

Aaaand we're live!

Note that we had to set it to use the new cedar-14 stack on Heroku and to use the dev environment for npm to install the dependencies properly.

crertel commented 7 years ago

Closing the ticket, and I'll start fixing the graph drawing next.