RoboticaUtnFrba / create_autonomy

ROS autonomy stack for iRobot Create 2.
BSD 3-Clause "New" or "Revised" License
28 stars 38 forks source link

Add LaMa #218

Closed FlorGrosso closed 4 years ago

FlorGrosso commented 4 years ago

Description

This PR adds Large Maps Framework (LaMa) as a new localization package.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Also list any relevant details for your test configuration.

export LOCALIZATION=lama
export RVIZ=true
export LASER=rplidar
roslaunch ca_gazebo create_house.launch

Using rviz, test navigation and localization.

Test Configuration:

Checklist:

eborghi10 commented 4 years ago

@FlorGrosso can you update the checklist that is in the PR description? I also added a few comments. PTAL.

FlorGrosso commented 4 years ago

Thanks @eborghi10 , comments addressed. I left a small question about the initial pose for the rest of the environment. Could you please take another look? thanks!

eborghi10 commented 4 years ago

@FlorGrosso as soon as you address the last comments, I'll approve it!

FlorGrosso commented 4 years ago

@eborghi10 I've added a response to your comment and made an update based on that. Could you please take a look and let me know if you agree? thanks!

FlorGrosso commented 4 years ago

Done @eborghi10 ! Rebased and comments addressed