search

RoboticsBrno / ServoESP32

⚙️ Generate RC servo signal on a selected pins with ESP32 device and Arduino framework.
MIT License
136 stars 32 forks source link

Order of parameters in attach #1

Open s00500 opened 6 years ago

s00500 commented 6 years ago

This library changes the order of parameters in the attach() function as compared to the standard arduino library, please change this or document it! Thanks

JarekParal commented 6 years ago

Yes, that is my fault. I'm probably creating a new interface for the function attach() with two options: 1) compatible with Arduino servo library - without parameter channel -> channel will be set automatically 2) parameter channel change from int to enum class and then the standard function overloading will work

What do you think about this change?

s00500 commented 6 years ago

yes perfect, I was also thinking about having the channel as an optional attribute :-)

JarekParal commented 5 years ago

Actually, I improve the documentation and in the future, I would like to refactor the library with cooperation to #2.