Added Support for ESP32-S2 & ESP-S3, configurable frequency and radians

RoboticsBrno / ServoESP32

⚙️ Generate RC servo signal on a selected pins with ESP32 device and Arduino framework.

MIT License

131 stars 31 forks source link

Added Support for ESP32-S2 & ESP-S3, configurable frequency and radians #23

Closed mikaeltulldahl closed 10 months ago

mikaeltulldahl commented 1 year ago

This is fork from @h2zero incorporating a fix for ESP32-S2 which turned out to also fix the same problem for ESP32-S3, where the resolution was configured to too high in ledcSetup.

The changes are only tested on an ESP32-S3-DevKitC-1. This should solve issue #18.

Added this functionality:

Configurable frequency
- Defaults to 50 hz
- Also tested at 333hz which is common for modern servos.
Users can now instantiate ServoFloat and ServoDouble in addition to Servo.
- This is to allow using radians, which would get truncated with integers. Also when using degrees this is beneficial if you want better resolution than 1 degree.
- The implementation must be in the header file for template classes.
- ServoBase class is shared between all template versions of ServoTemplate, so the static variable channel_next_free is shared.
- Added an example for how to use ServoFloat with radians.

mikaeltulldahl commented 10 months ago

Hello @JarekParal is it possible to get this merged?

JarekParal commented 10 months ago

@mikaeltulldahl Hello, thank you very much for your PR. All the changes seems to be good. I merged it and I'm going to release it as version 1.1

mikaeltulldahl commented 10 months ago

Great! If possible, could you also publish the update on PlatformIO with pio pkg publish?

JarekParal commented 10 months ago

Do you know if the automatic update of PlatformIO libraries still works or it has to be done only with pio pkq publish?

mikaeltulldahl commented 10 months ago

I think it is a manual step. I see you did a release here on github but it didn't became available on PlatformIO

On Wed, 30 Aug 2023, 06:49 Jaroslav Páral, @.***> wrote:

Do you know if the automatic update of PlatformIO libraries still works or it has to be done only with pio pkq publish?

— Reply to this email directly, view it on GitHub https://github.com/RoboticsBrno/ServoESP32/pull/23#issuecomment-1698487792, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEMWKZI2ZFD2K4TGJ4BSCDXX3A67ANCNFSM6AAAAAAXT2WGAM . You are receiving this because you were mentioned.Message ID: @.***>

JarekParal commented 10 months ago

The automatic update from GitHub Release is still working on PIO:

mikaeltulldahl commented 10 months ago

Ah yes, my mistake