Update library properties

RoboticsBrno / ServoESP32

⚙️ Generate RC servo signal on a selected pins with ESP32 device and Arduino framework.

MIT License

136 stars 32 forks source link

Update library properties #8

Closed platisd closed 4 years ago

platisd commented 4 years ago

Update the library URL to point to the actual library and not the default Arduino one and select a more unique name so to avoid conflicts with another ESP32Servo library in Arduino IDE's library manager.

Can you also please consider adding this great work of yours to the Arduino IDE library manager? It would make my life much easier. :)

You can do this by following these instructions.

JarekParal commented 4 years ago

Hi @platisd, thank you for your PRs. I will review them during the weekend. Is that ok for you?

platisd commented 4 years ago

Hi @platisd, thank you for your PRs. I will review them during the weekend. Is that ok for you?

Sounds good! Thanks!

platisd commented 4 years ago

Is there any status update regarding this? :smiley_cat:

JarekParal commented 4 years ago

Excuse me for a delayed answer but I had some issue with compilation this library in new Arduino IDE 1.8.11. But it was just some problem with my PC and restart of the PC solved this issue.

I checked the other libraries in the Library Manager and I found just ESP32Servo which is not in the conflict with my library ServoESP32:

I also use this name ServoESP32 on PlatformIO.

Then if you agree I would like to publish this library in Arduino Library Manager under the name ServoESP32 and I could also change the name of the repository and link in the library.property.

Do you agree? @platisd

platisd commented 4 years ago

Oh, I must have missed that it was actually a different name. Then it's fine! I have stupidly removed the forked repo so I'll either need to create a new pull request or you can go ahead and make the small change regarding the URL yourself. :)

JarekParal commented 4 years ago

Ok, then I will make these changes hopefully today or tomorrow.

platisd commented 4 years ago

You're awesome! :rocket:

JarekParal commented 4 years ago

@platisd I changed the name of the repository and also updated the URLs for the library in property files.

I applied for adding to the Arduino Library Manager: https://github.com/arduino/Arduino/issues/9690

Now we must just wait.

If you will have any ideas for improvements, let me know or send PR.

platisd commented 4 years ago

Thanks, will do if I've got something. :)