search

RoboticsClubIITJ / ML-DL-implementation

An implementation of ML and DL algorithms from scratch in python using nothing but NumPy and Matplotlib.
BSD 3-Clause "New" or "Revised" License
48 stars 69 forks source link

Fixed the unit step function #100

Closed parva-jain closed 3 years ago

parva-jain commented 3 years ago

This PR corresponds to issue #99. Fixed the implementation of unit step function.

kwanit1142 commented 3 years ago

Before pull requesting, did you tested the program that whether your output is desired now?

kwanit1142 commented 3 years ago

Kindly add test for the function, AS FROM NOW , adding test will be compulsory , else Pull Request will not get merged

parva-jain commented 3 years ago

Before pull requesting, did you tested the program that whether your output is desired now?

yes

parva-jain commented 3 years ago

Kindly add test for the function, AS FROM NOW , adding test will be compulsory , else Pull Request will not get merged

Alright. One more thing, my points in the leaderboard are not getting updated and no one responding to my messages in gitter. Please acknowledge if u are one of the maintainers.

agrawalshubham01 commented 3 years ago

@parva-jain don't worry about your leaderboard it will be updated. Rohan was a busy ig he will update withing a day or 2.

parva-jain commented 3 years ago

@parva-jain don't worry about your leaderboard it will be updated. Rohan was a busy ig he will update withing a day or 2.

Is there something wrong with this PR?