RoboticsClubIITJ / ML-DL-implementation

An implementation of ML and DL algorithms from scratch in python using nothing but NumPy and Matplotlib.
BSD 3-Clause "New" or "Revised" License
49 stars 69 forks source link

Huber Loss Function #24

Closed Hinal-Srivastava closed 3 years ago

Hinal-Srivastava commented 4 years ago

Huber Loss Function Huber loss approaches MSE when 𝛿 ~ 0, i.e for smaller values and MAE when 𝛿 ~ ∞, i.e for larger values. Viyet References:

  1. Documentation on Huber Loss Function
  2. Video on Huber Loss Function

Reference Issue #21

agrawalshubham01 commented 4 years ago

@Hinal-Srivastava https://github.com/RoboticsClubIITJ/ML-DL-implementation/blob/d73e1460762635cff3892e8f168dbb64eadba5ca/MLlib/loss_func.py#L5-L15

@rohansingh9001 any other point need to be added?

Hinal-Srivastava commented 4 years ago

@Hinal-Srivastava https://github.com/RoboticsClubIITJ/ML-DL-implementation/blob/d73e1460762635cff3892e8f168dbb64eadba5ca/MLlib/loss_func.py#L5-L15

  • Here only 3 parameters are taken i.e instead of W*X+B we are just using W*X reason being we have added bias row/column. Kindly Correct this in your code.
  • Also you have in loss only loss is calculated and is independent of iteration (Review the above code), And add function derivative which calculates derivative of the function given

@rohansingh9001 any other point need to be added?

Yes I'll change these ASAP. Sorry for the late reply

rohansingh9001 commented 4 years ago

There are merge errors, build errors and no updates for a long time. Closing this PR for now. The author can open a new PR when it is done.

TarunTomar122 commented 3 years ago

Closed Due to Inactivity!