search

RoboticsClubIITJ / ML-DL-implementation

An implementation of ML and DL algorithms from scratch in python using nothing but NumPy and Matplotlib.
BSD 3-Clause "New" or "Revised" License
49 stars 69 forks source link

Added Visualize class #26

Closed PawanSuryavanshi95 closed 3 years ago

PawanSuryavanshi95 commented 4 years ago

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

rohansingh9001 commented 4 years ago

This PR has the same problem as PR #13 where the graph is plotted once after the training is completed while is can be plotted live which updates for each and every epoch. @uakarsh was already assigned this issue. He has already made a PR #13 with the same functionality as this.

TarunTomar122 commented 4 years ago

@rohansingh9001 i think this class that he wrote is good enough. Why do you want the graph to update on every epoch? Even for standard frameworks the graph is shown once the training is done!

PawanSuryavanshi95 commented 4 years ago

Let me have a look at this, it can be shown during training too.

On Sun, Oct 4, 2020 at 9:28 AM Tarun Tomar notifications@github.com wrote:

@rohansingh9001 https://github.com/rohansingh9001 i think this class that he wrote is good enough. Why do you want the graph to update on every epoch? Even for standard frameworks the graph is shown once the training is done!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RoboticsClubIITJ/ML-DL-implementation/pull/26#issuecomment-703198284, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANRL2ZURWA4GDFXRSL27HYLSI7XG7ANCNFSM4SBQ7L7A .

rohansingh9001 commented 4 years ago

@uakarsh is working on live updates. For now we can merge this PR.

rohansingh9001 commented 4 years ago

@PawanSuryavanshi95 rename the example file to what is in the repository now. The names of the files have to been updated from example.py to linear_example.py and logistic_example.py.

Rest LGTM.

TarunTomar122 commented 4 years ago

@rohansingh9001 @PawanSuryavanshi95 Can we do this for all models?!

rohansingh9001 commented 4 years ago

The visualize class added here should be usable for all models and not just one model. @PawanSuryavanshi95 @TarunTomar122.

If that is not the case, this may need to be updated. Also, there are merge conflicts. That needs to be fixed as well.

TarunTomar122 commented 3 years ago

Closed due to Inactivity!