search

RoboticsClubIITJ / ML-DL-implementation

An implementation of ML and DL algorithms from scratch in python using nothing but NumPy and Matplotlib.
BSD 3-Clause "New" or "Revised" License
48 stars 69 forks source link

Implementation of bayesian optimization #70

Closed bhanuexcalibur closed 3 years ago

bhanuexcalibur commented 3 years ago

Fixes #65 Implementation of bayesian optimization

rohansingh9001 commented 3 years ago

@bhanuexcalibur While the code might work fine, however this is not how other algorithms are implemented in our repository.

Please look at some other algorithms to see how we implemented those. They are done in such a way so that a user can import our library and use your algorithm like one normally does.

Also your code is not following PEP8 standards due to which the checks have failed. Go to this link to see your errors, they start from line 232.

Thanks for contributing!

kwanit1142 commented 3 years ago

Due to Inactivity, I am closing this PR now.