search

RoboticsClubIITJ / ML-DL-implementation

An implementation of ML and DL algorithms from scratch in python using nothing but NumPy and Matplotlib.
BSD 3-Clause "New" or "Revised" License
48 stars 69 forks source link

Evaluation metrics #76

Closed Prachi0203 closed 3 years ago

Prachi0203 commented 3 years ago

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

rohansingh9001 commented 3 years ago

@Prachi0203 in your code, you have used the zip() function which returns a list which might not be the most optimal code in this case. Use some NumPy array compatible functions like hstack or vstack instead.

The spelling of false on line 22 is incorrect.

Also, your code formatting is not following PEP 8 standards. Go to this link to see where the errors are, all the errors start from line 232. To check for these errors locally use flake8 or some suitable formatting checker.

Also, move the file from the Examples folder to MLlib. The destination of the file should be MLlib/metrics.py.

Please make these changes so that I can check your code further. The logic for the functions seems correct, however, I can check them after you make these changes. Thanks for Contributing!

kwanit1142 commented 3 years ago

@Prachi0203 a more optimized approach for file is to make class with variables contained in self_init() and score definitions , just using those variables. I hope it will give a valuable insight to you.

Prachi0203 commented 3 years ago

Yeah sure I will make changes. This was my first contribution.... :) so thank you for insights

On Sun, 6 Dec 2020, 3:34 pm Kwanit Gupta, notifications@github.com wrote:

@Prachi0203 https://github.com/Prachi0203 a more optimized approach for file is to make class with variables contained in self_init() and score definitions , just using those variables. I hope it will give a valuable insight to you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RoboticsClubIITJ/ML-DL-implementation/pull/76#issuecomment-739480948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN735CB5PZRTNCV7WSOPAZ3STNJL3ANCNFSM4UON6VXQ .

rohansingh9001 commented 3 years ago

Yeah sure I will make changes. This was my first contribution.... :) so thank you for insights

Feel free to use the Gitter Channel to ask any doubts. Any maintainer of our repository may answer your queries.

kwanit1142 commented 3 years ago

@Prachi0203 , any updates regarding implementation ?

Prachi0203 commented 3 years ago

@kwanit1142 I am working on it. Give me another day I will add more metrics too

kwanit1142 commented 3 years ago

Due to prolonged Inactivity, I am freeing the Issue to be solved by others.