search

RoboticsTeam4904 / standard

Command Based Git Submodule
BSD 3-Clause "New" or "Revised" License
11 stars 3 forks source link

Replace Encoder Group with Encoder Pair #145

Closed carturn closed 7 years ago

carturn commented 7 years ago

Encoder Group seems to have limited use cases and limitations due to it using N-encoders. Therefore, I am proposing replacing it with a pair of encoders, which I think covers most of our uses for multiple encoders together. I think this will simplify implementation of encoder based chassis driving systems.

carturn commented 7 years ago

@ave4224 would this help with the encoder based chassis move you were working on?

carturn commented 7 years ago

Is this something we actually want to do in general? I would prefer not to waste time cleaning this up if we are not going to use it.

leijurv commented 7 years ago

Aren't there various encoder pairs on the chassis?

carturn commented 7 years ago

This is partially tested; should we test the PID capabilities of this before merging? I am inclined to think that given that the getDistance and getDifference functions work, the PID will work as well.