search

RoboticsTeam4904 / standard

Command Based Git Submodule
BSD 3-Clause "New" or "Revised" License
11 stars 3 forks source link

CapSpeedModifier #151

Closed NikhilSuresh24 closed 7 years ago

NikhilSuresh24 commented 7 years ago

Added a CapSpeedModifier that implements speedmodifier but sets speeds according to an upper and lower bound given to it

leijurv commented 7 years ago

I would suggest using limitValue from Util.Range for consistency (from https://github.com/RoboticsTeam4904/standard/blob/master/Util.java) @c0d3rman

c0d3rman commented 7 years ago

Agreed, good catch @leijurv

ajnadel commented 7 years ago

@NikhilSuresh24 (@c0d3rman) maybe consider adding a constructor that takes in an existing Util.Range in addition to that one?

c0d3rman commented 7 years ago

@leijurv Made the changes you requested

leijurv commented 7 years ago

Noticed something while taking another glance, I'm not sure if this is the convention, but you can do import org.usfirst.frc4904.standard.Util.Range; and then refer to the class as just Range and not Util.Range.

Now it feels like importing import org.usfirst.frc4904; and using standard.Util.Range everywhere (even though you can't actually do that lol)

c0d3rman commented 7 years ago

Since Range is a class within Util I think this is proper usage

leijurv commented 7 years ago

"proper" says who =P

c0d3rman commented 7 years ago

Says me

leijurv commented 7 years ago

GOTEM

ajnadel commented 7 years ago

@leijurv takes the L

leijurv commented 7 years ago

ill take your L