search

RoboticsTeam4904 / standard

Command Based Git Submodule
BSD 3-Clause "New" or "Revised" License
11 stars 3 forks source link

Added a PID stop condition based on derivative #190

Closed c0d3rman closed 5 years ago

c0d3rman commented 7 years ago

Added a stop condition to CustomPIDController based on how close the derivative is to zero. This is to prevent the loop ending as soon as it reaches zero error but is about to overshoot. It is also useful for P or PD loops, where the error doesn't converge to zero and the loop should end once the error is stable.

billwpierce commented 7 years ago

Is there a reason this hasn't been merged?

ajnadel commented 7 years ago

@billwpierce as far as I'm concerned, this hasn't been well tested. We can do that and then merge?

oshlern commented 6 years ago

We were using this on the 2018 bot and I don't know if it actually worked but it didn't break anything