RoboticsTeam4904 / standard

Command Based Git Submodule
BSD 3-Clause "New" or "Revised" License
11 stars 3 forks source link

Cancel updates #247

Closed Exr0n closed 4 years ago

Exr0n commented 4 years ago

Fixed standard/commands/Cancel.java

Exr0n commented 4 years ago

Please do not review, as the code changes are not up to standard as defined by Daniel on slack:

Hey everyone, a few notes about standard updates: for requirements, please use the following format (its a little different than what we were doing before, but this is what Rohan and the WPILib devs do):

@Override
public Set<Subsystem> getRequirements() {
return Set.of(...requirements...);
}

...requirements... is a Vararg, so just provide a command separated list of subsystems (or a single subsystem with no commas) for initDefaultCommands, please delete the entire method and add a javadoc to the class that the method was formerly a member of saying what command should be set as the default. Default commands are now set when the subsystem is instantiated as subsystems no longer need to have knowledge of their default commands. If you have questions about javadocs, please ask me or nikhil. Generally avoid wildcard imports (*) as they clutter the local namespace. Please only import what you use. command.start() is now essentially command.schedule(). command.initialize() is still command.initialize().

Exr0n commented 4 years ago

Fixed the issues, please review :)