search

RobotnikAutomation / summit_xl_common

URDF description of the Summit XL and Summit XL HL, platform messages and other files for simulation.
BSD 2-Clause "Simplified" License
72 stars 47 forks source link

Added xacro: for cylinder_inertia use in wheel urdfs. #13

Closed GeraldHebinck closed 3 years ago

GeraldHebinck commented 3 years ago

As xacro tags should be used with namespace, this PR fixes this for the usage of the cylinder_inertia macro. This fixes the warning in Melodic. Furthermore, the urdf will be created correctly for Noetic.

Please see xacro - ROS Wiki Section 13. Deprecated Syntax

GeraldHebinck commented 3 years ago

Actually, the commit to add the param to disable tf publish for real robot should not have been part of this PR. I guess commiting something after starting a PR might just add the commit to the PR.

RomanRobotnik commented 3 years ago

Thanks for the PR!

Either I can merge the commit for the tf too o maybe you undo the commit and push it again to update the PR.

GeraldHebinck commented 3 years ago

As removing the commit did not work the way i expected, it is up to you to merge both commits or close the PR. Integrating the the option to disable the TF publish is useful but it was not planed to be in this PR.