Added 'velocity_controllers/JointPositionController's for pan and tilt links

RobotnikAutomation / summit_xl_common

URDF description of the Summit XL and Summit XL HL, platform messages and other files for simulation.

BSD 2-Clause "Simplified" License

72 stars 47 forks source link

Added 'velocity_controllers/JointPositionController's for pan and tilt links #5

Closed thesidjway closed 5 years ago

thesidjway commented 5 years ago

The pan & tilt joints of the axis camera on the summit_xl had no apparent control in the package earlier. Also robotnik_sensors/urdf/axis.urdf.xacro had the link listed as a JointPositionController, which has no support for PID params and thus leads to unnatural motions upon setting a target angle. I have created another PR in the robotnik_sensors repository addressing the same (https://github.com/RobotnikAutomation/robotnik_sensors/pull/6 )

RomanRobotnik commented 5 years ago

Thank you for your contribution. Both pull requests have been merged.