search

RobotsAndPencils / RPSlidingMenu

A collection view menu in the style of UltraVisual.
MIT License
861 stars 109 forks source link

Correct the content size computed in Layout class #15

Closed vincentsaluzzo closed 10 years ago

interstateone commented 10 years ago

Hey @vincentsaluzzo, thanks for this big PR! It might take a bit more time to go through all of it.

Quickly skimming, it seems like there are some changes that aren't part of the PR title? I noticed things like changing dimensions, adding a separator view, hiding the text label, etc. Are these relevant to correcting the content size or things that you've changed for your own use? Thanks in advance for clarifying this :smile:

vincentsaluzzo commented 10 years ago

Hi @interstateone, Sorry, i made a mistake when a I submit the pull request.

I want to suggest you only the commit 4411dc6c44f2226610eec876602b752aab62a9d7 "Correct the content size computed in Layout class"

All the rest of commit are essentialy a customization of your component (separator cell, text label dissapear, etc.)

I think I will rename the componant on our account to be more reprensative of new behavior (accordeon, etc.)

paulthorsteinson commented 10 years ago

@vincentsaluzzo thanks for the PR! It would be easier if you submit that as a separate pull with just that commit. That being said, if you just change that one line the menu never scrolls up to the top, it only scrolls to the second last cell. I will close this one and if you want to submit that commit separately and fix the issue with it then I will look at it as soon as I see the PR. Thanks!