RobotsAndPencils / RPSlidingMenu

A collection view menu in the style of UltraVisual.
MIT License
861 stars 109 forks source link

Cell layout width depending on orientation #16

Closed Lascorbe closed 10 years ago

interstateone commented 10 years ago

Hey @Lascorbe, thanks for the contribution! I did a quick run of the demo project and it seems like the cells aren't laying out correctly, see below:

screenshot 2014-05-15 18 58 04

Do you think you could take a look?

Lascorbe commented 10 years ago

Fixed, [[UIDevice currentDevice] orientation] doesn't work on the simulator. I've also:

It should work now :smile:

interstateone commented 10 years ago

Looks great! The only other thing that I noticed was that scrolling past the bottom cell sometimes went too far, as if there was an invisible cell at the bottom. I also tried applying the change from #14 (i.e. I don't think your changes caused that issue, but are maybe revealing them) and that seemed to fix the issue, so given everything else looks good we'll look at merging them in that order.

Lascorbe commented 10 years ago

Hey @interstateone, any updates on this? :smile:

paulthorsteinson commented 10 years ago

@Lascorbe It's really nice to have the demo be universal. My only issue with this right now is that it needs to handle rotation better. When it rotates I would expect the cell to take up the whole width and the image to be centered. Right now on iPad or iPhone if I rotate it only takes up the left side. Also on the iphone as you rotate to upside down the cell is stuck in the wrong orientation. On iPad if you scroll to last menu item and rotate then there are no visible cells as it goes off screen. Love the end goal, just needs to work smoothly when rotated.

Lascorbe commented 10 years ago

@paulthorsteinson Great feedback, I'll look into those issues, thanks!

interstateone commented 10 years ago

@Lascorbe Did you have a chance to look into this? If not I'll close it for now, but we can always reopen it when you're ready with changes.