search

RobotsAndPencils / buford

A push notification delivery engine for the new HTTP/2 APNS service.
MIT License
475 stars 52 forks source link

NewClient with no errors and support for Go 1.5 #55

Closed nathany closed 8 years ago

nathany commented 8 years ago

Using x/net/http2 directly instead of ConfigureTransport could allow support for Go 1.5.x (if desired), and make it so NewClient() doesn't return an error.

https://github.com/sideshow/apns2/blob/master/client.go#L60

nathany commented 8 years ago

With Go 1.7 coming out in a few months, I don't see a lot of value in adding support for Go 1.5. But not needing to return an error would be nice.

nathany commented 8 years ago

63 JWT would remove the need for NewClient.