search

RobotsAndPencils / buford

A push notification delivery engine for the new HTTP/2 APNS service.
MIT License
475 stars 52 forks source link

push.Error not containing DeviceToken #86

Closed omerkirk closed 8 years ago

omerkirk commented 8 years ago

In the previous versions of buford, the error struct had a field for device token of the notification. This was useful since for some errors (ie. ErrUnregistered) the device token needs to be removed from the backend. In the latest version this field seems to have been removed from the error struct. This causes an issue in the concurrent scenario (push.NewQueue( service, workers) where there is no way to track for which device the error is received and makes it hard to act on it.

omerkirk commented 8 years ago

Sorry I didn't read the code before openning the issue, the response struct seems to contain the DeviceToken in the queue usage.