search

RobotsAndPencils / buford

A push notification delivery engine for the new HTTP/2 APNS service.
MIT License
474 stars 52 forks source link

Fix for cert verify in Go 1.10 #92

Closed kmcrawford closed 6 years ago

kmcrawford commented 6 years ago

In Go 1.10 returns: certificate specifies an incompatible key usage: asn1.ObjectIdentifier{1, 3, 6, 1, 5, 5, 7, 3, 1} for APNS cert. This code change will catch and ignore this error.

kmcrawford commented 6 years ago

I am not sure why travis failed to build. I have tested this locally back to 1.7.5

nathany commented 6 years ago

This is the TravisCI failure:

 --- FAIL: TestNewClient (0.10s)
    service_test.go:22: certificate has expired or is not yet valid
kmcrawford commented 6 years ago

It looks like the cert used in the test has expired. This is irrelevant of the code change.

codecov-io commented 6 years ago

Codecov Report

Merging #92 into master will decrease coverage by 0.28%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   56.16%   55.88%   -0.29%     
==========================================
  Files          11       11              
  Lines         308      306       -2     
==========================================
- Hits          173      171       -2     
  Misses        116      116              
  Partials       19       19
Impacted Files Coverage Δ
push/header.go 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6d71af...72c4e37. Read the comment docs.

kmcrawford commented 6 years ago

@nathany I updated the expired cert to a valid one. The tests now pass.

nathany commented 6 years ago

Thank you Ken!