search

RobotsAndPencils / buford

A push notification delivery engine for the new HTTP/2 APNS service.
MIT License
475 stars 52 forks source link

APNS Cert fails validation on Go 1.10 #93

Closed kmcrawford closed 6 years ago

kmcrawford commented 6 years ago

In Go 1.10 returns: certificate specifies an incompatible key usage: asn1.ObjectIdentifier{1, 3, 6, 1, 5, 5, 7, 3, 1} for APNS cert.

This is keeping us from upgrading our systems to use Go 1.10.

  1. What version of Go are you using (go version)? go version go1.10 darwin/amd64
  2. What operating system (GOOS) are you using (go env) and what version? OSX, Apline
  3. What did you do? (steps to reproduce or a code sample is helpful) Attempt to do push notification using a valid cert.
  4. What did you expect to see? The push to go through.
  5. What did you see instead? An error.

A proposed fix is in: https://github.com/RobotsAndPencils/buford/pull/92

kmcrawford commented 6 years ago

Any comments on this? I hate to fork this repo to fix this issue.

nathany commented 6 years ago

thanks for the fix.