search

RobotsAndPencils / go-saml

A just good enough SAML client library written in Go.
MIT License
132 stars 82 forks source link

Generates invalid metadata? #9

Open lpar opened 8 years ago

lpar commented 8 years ago

The generated metadata includes this clause:

 <md:Extensions xmlns:alg="urn:oasis:names:tc:SAML:metadata:algsupport" xmlns:mdattr="urn:oasis:names:tc:SAML:metadata:attribute" xmlns:mdrpi="urn:oasis:names:tc:SAML:metadata:rpi">
        <EntityAttributes></EntityAttributes>
    </md:Extensions>

This is flagged as invalid according to the XSD schema when validated using https://www.samltool.com/validate_xml.php

In addition, https://www.testshib.org/ refuses the file as invalid.

If I delete the entire <md:Extensions> element from the generated metadata, the file then validates and is also accepted by testshib.org. Since the element doesn't seem to contain any actual information, I'm guessing it isn't needed.

zetaab commented 6 years ago

I can confirm this, xml is not valid. Do we really need this <md:Extensions> element?