RobotsAndPencils / react-gantry

R&P's React Starter Kit
4 stars 1 forks source link

.vscode directory defaults? #24

Open akrigline opened 6 years ago

akrigline commented 6 years ago

Should we include a .vscode directory with gantry including our workspace recommended settings (disable eslint, enable standard, enable format on save from standard, recommended extensions, etc)?

It is a really nice thing that vscode lets us do, but at the same time this folder is basically useless for anyone using any other IDE.

akrigline commented 6 years ago

@dfagan2 @stuarttannehill-rp Thoughts here?

dfagan2 commented 6 years ago

@akrigline - i would prefer those recommendations just live in documentation somewhere, not as actual files. such documentation could even point to an un-merged PR/branch for easy pull down of actual files

akrigline commented 6 years ago

I think that the .vscode directory adds a lot of value to people using vscode for very little cost to people not using vscode. Additionally, since R&P's front enders mostly all use it, it's basically become the opinion. As that opinion evolves, I expect that gantry will evolve with it.

Between all of these things, I would never want to spin up a project without a vscode directory:

akrigline commented 6 years ago

I also am not opposed to the idea of us making an Atom or sublime text equivalent to the directory that lives in the repo. If gantry's goal is to make it easier to start working on a React app, these defaults will only help that.

dfagan2 commented 6 years ago

just want to be careful to keep our opinions on the React code, not other intangibles or preferences, as that can be a slippery slope. that said, i could be persuaded by the above.

@stuarttannehill-rp - what do you think?