Proposed Thunks Revisions

bindActionCreators removed

Its use case is pretty niche apparently and in this case in particular we can avoid it by simply giving mapDispatchToProps an object instead of a function.

The only use case for bindActionCreators is when you want to pass some action creators down to a component that isn't aware of Redux, and you don't want to pass dispatch or the Redux store to it.

Default Export Actions

Switched to a default export for actionCreators. I think this is an opinion thing that we as a group will need to settle on. I personally think this is easier to follow and maintain than import * syntax.

We don't import types unexpectedly
Naming the import is simple

Container Restructure

~Per this discussion around binding, there are a few things we have in our container that are not ideal.~

~Two things we're not supposed to do are:~

~Anonymous functions within render~
- ~These functions are created and discarded with each time the component renders, which can create a performance sink. The function passed to the components below this one are forced to re-render because for a prop of onClick: () => this.getProfileDetails() !== () => this.getProfileDetails().~
~Bind this within render.~
- ~This has the same performance problems as anonymous functions. The bindings are broken and remade with each render, which causes rerenders all the way down the line.~

~As such I created getProfileDetails() and bound it within the constructor.~

I recind this based on this article. Inline function binds this perfectly fine for this use case.

RobotsAndPencils / react-gantry