search

RobotsAndPencils / react-gantry

R&P's React Starter Kit
4 stars 1 forks source link

node-sass deprecated #52

Open amritk opened 3 years ago

amritk commented 3 years ago

node-sass is deprecated, we should switch to dart sass

https://sass-lang.com/blog/libsass-is-deprecated

danactive commented 3 years ago

Oh nice, I just noticed this too, as ~@johnsalzy~ You (I didn't release you were in our codebase yet!) committed a change working on making the change for Caresix. Unexpectedly the async npm module is slower than the sync. Maybe we should use the CLI?

amritk commented 3 years ago

@danactive oh I didn't see that, I made a PR as well. Sure as long as it works with sass-resources-loader or whatever sass tools we are using 👍🏾

danactive commented 3 years ago

Move discussion to your Caresix PR