New goal service, feasibility feature and dimensions bug solved

Roboy / gym-roboy

Pip package gym environment for deep roboy control

2 stars 1 forks source link

New goal service, feasibility feature and dimensions bug solved #8

Closed BarisYazici closed 5 years ago

BarisYazici commented 5 years ago

Is everything resolved? @tomasruizt @ALPA-Industry-and-Technology

tomasruizt commented 5 years ago

No, there is still comments that remain unaddressed.

tomasruizt commented 5 years ago

I commented the part that is buggy. I found it by running this comamnd from the gym_roboy/envs/tests folder: python3 -m pytest --run-integration --disable-warnings -v test_msj_env.py -s

BarisYazici commented 5 years ago

python3 -m pytest --run-integration --disable-warnings -v test_msj_env.py -s

I got 5 passed 2 skipped response after this command.

BarisYazici commented 5 years ago

I commented the part that is buggy.

Good catch. That was the reason of not getting loss graphs. Since it was stucked there. Tensorboard works now

tomasruizt commented 5 years ago

I renamed the method, since you did not