Roboy / ravestate

✨ Ravestate is Roboy's reactive dialogue state library.
http://roboy.github.io/ravestate
BSD 3-Clause "New" or "Revised" License
25 stars 7 forks source link

ROS1 in Ravestate #119

Closed Toseban closed 5 years ago

Toseban commented 5 years ago

Fixes #116 The same interface between properties and ROS we have in ravestate_ros2, only this time with ROS1 :older_man: What's left to do:

codecov-io commented 5 years ago

Codecov Report

Merging #119 into velvet-revolution will decrease coverage by 2.8%. The diff coverage is 0%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           velvet-revolution     #119      +/-   ##
=====================================================
- Coverage              75.29%   72.49%   -2.81%     
=====================================================
  Files                     57       59       +2     
  Lines                   3550     3686     +136     
=====================================================
- Hits                    2673     2672       -1     
- Misses                   877     1014     +137
Impacted Files Coverage Δ
modules/ravestate_ros1/ros1_properties.py 0% <0%> (ø)
modules/ravestate_ros1/__init__.py 0% <0%> (ø)
modules/ravestate_telegramio/telegram_bot.py 42.3% <0%> (ø) :arrow_up:
modules/ravestate/causal.py 92.52% <0%> (-0.47%) :arrow_down:
modules/ravestate/constraint.py 91.77% <0%> (-0.33%) :arrow_down:
modules/ravestate_idle/__init__.py 100% <0%> (+6.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7a391b...8766e0b. Read the comment docs.

josephbirkner commented 5 years ago

Hmm, the test situation is hard to decide. Technically what we could do is use our docker image in travis. Then we could write amazing tests... Let's create an issue for that.

josephbirkner commented 5 years ago

Follow-up: #120

Toseban commented 5 years ago

rospy is already in the docker image