Closed liiight closed 8 years ago
Can you add tests to this, similar to the GitHub table tests?
Yeah, sure. Sorry for not doing this upfront. Also, I'll add the table to the main init.py
Dunno why build failed, probably took too long. I suggest triggering different build for each py version, it'll be faster (Travis can run simultaneously).
Also another thing.
Ideally PorcelainTable should not show any colors. I do this now in my soltuion using some partial
hackery. Ideally, this should/could be baked in BaseTable using a allow_colors
flag that can be checked when generating the table.
This however means coupling terminaltables
with a color library (let's say, colorclass
for example :wink: ). I'm more than willing to make that PR, just not sure if that's something you want/agree with.
Ugh, why did that break. I'll look into why ssh-add is prompting for a password for an ssh key with no password set. Your PR looks fine so I'll merge it.
I can't run multiple Travis jobs per build because Coveralls.io doesn't combine coverage from Travis and AppVeyor. I have to combine all coverage myself and then send it from Travis once.
The colors thing is a bit out of scope for terminaltables. If you want to remove colors I would do it in your application. Either regex strip it out before passing strings to terminaltables or use colorclass which can strip colors.
Thanks. I just check if I pass table type as porcelain and if so just not apply color: https://github.com/Flexget/Flexget/pull/1307/files#diff-487b1eb870fb818194584ff5fe02f66cR511 There's another topic I'd like to discuss, word wrapping when needed. Not sure if this is the best forum though.
There's an issue for that: https://github.com/Robpol86/terminaltables/issues/5
Cool. Word wrap is very tricky as it involves many design decisions (which column to wrap, etc.)
When is a new version expected to be released?
Probably not for a long time unfortunately. I've got one or two other projects I want to work on before taking care of more issues here. Maybe in a month I can consider making a quick release.
Well with your coverage I'd consider just doing ci. I'll keep an eye out for release though, thanks!
FYI I've just released a new version.
nice, thanks for the heads up!
Added a class that'll emulate
git --porcelain
option, useful for stuff (at least I'll use it :smile: ).