search

Robpol86 / terminaltables

Project no longer maintained.
https://github.com/matthewdeanmartin/terminaltables
MIT License
689 stars 70 forks source link

add bottom row feature #6

Closed aleivag closed 9 years ago

aleivag commented 9 years ago

I actually use this (add a line before last row) for a project to get something like

+-------------------------------+--------+---------+--------+----------+-----------+
| Prod                          |   Hits | AVG RUM | US RUM | REALTIME | relevance |
+-------------------------------+--------+---------+--------+----------+-----------+
| https://ww1.emtinelcewloc.com |    947 |     2.5 |    2.3 |      1.4 |       9.3 |
| https://ww2.emtinelcewloc.com |  1,706 |     2.5 |    2.2 |      2.1 |      16.8 |
| https://ww3.emtinelcewloc.com |  1,925 |     2.6 |    2.6 |      2.4 |      18.9 |
| https://ww4.emtinelcewloc.com |  1,404 |     3.0 |    2.6 |      1.9 |      13.8 |
| https://ww5.emtinelcewloc.com |    777 |     2.4 |    2.3 |      1.3 |       7.6 |
| https://ww6.emtinelcewloc.com |  1,459 |     2.5 |    2.3 |      2.4 |      14.3 |
| https://ww7.emtinelcewloc.com |    210 |     5.3 |    2.9 |      0.0 |       2.1 |
| https://ww8.emtinelcewloc.com |  1,749 |     3.2 |    2.8 |      2.4 |      17.2 |
+-------------------------------+--------+---------+--------+----------+-----------+
| Total                         | 10,177 |     2.8 |    2.5 |      2.1 |           |
+-------------------------------+--------+---------+--------+----------+-----------+

maybe it can help someone else...

Robpol86 commented 9 years ago

Can you fix the tests?

Robpol86 commented 9 years ago

Looks like tests failed because of other libraries. I'll check this out later tonight or tomorrow.

aleivag commented 9 years ago

looks like you are right, i'll happily look at it tomorrow and see if i can check what was it...

Alvaro Leiva

On Sat, May 30, 2015 at 8:20 PM, Robpol86 notifications@github.com wrote:

Looks like tests failed because of other libraries. I'll check this out later tonight or tomorrow.

— Reply to this email directly or view it on GitHub https://github.com/Robpol86/terminaltables/pull/6#issuecomment-107114299 .

Robpol86 commented 9 years ago

I'm gonna go ahead and merge your changes before I merge mine in. I'll be changing inner_bottom_row_border with inner_footing_row_border to keep the terminology the same (e.g. heading and footing).

Good work, thanks!