search

RobustPerception / azure_metrics_exporter

Azure metrics exporter for Prometheus
Apache License 2.0
133 stars 70 forks source link

Cut down on fatal errors #23

Closed carlpett closed 6 years ago

carlpett commented 6 years ago

In azure.go, there are currently 15 uses of log.Fatalf. Which of them are reasonable to keep as fatal? For example, partial configuration errors (such as pointing to non-existing resources, which gives a 404) will right now quit the exporter. Some errors might make sense to quit with (invalid credentials, perhaps), but most not. Happy to do the changes when there is agreement on what is best.

Ping @brian-brazil

brian-brazil commented 6 years ago

The initial config being bad is the only thing that should probably kill it.