RobustPerception / azure_metrics_exporter

Azure metrics exporter for Prometheus
Apache License 2.0
133 stars 70 forks source link

Feature : implement --list.definitions with resource group config #48

Closed louisfelix closed 5 years ago

louisfelix commented 5 years ago

Hi!

When calling ./azure_metrics_exporter --list.definitions with a resource_group configuration, no output appears. This is "normal" as I see the feature is not implemented for resource group.

I propose to implement it. It will need a small refactor to the Collect function; i.e., extract as a function the logic for include/exclude of the resource groups, in order to avoid code duplication.

I can start to work on that PR next week.

Thanks!

brian-brazil commented 5 years ago

Makes sense to me.