Closed jeremywrnr closed 9 years ago
These commits could and should probably be condensed/flattened into more meaningful ones, as there are backup or output files were occasionally committed ( 15dbc570 ), which would unnecessarily bloat the master branch's history and size. I don't really have experience w/ condensing or flattening commits though, so any guidance or suggestions will be appreciated.
If you would like to combine some of the commits, in this branch run git rebase -i master
to do interactive rebase of commits from master to your current HEAD. Then you will get a list of commits with a keyword for each one. You can reorder the lines to change the order of the commits. Combine commits by changing the keyword of successive ones to squash
(to keep the commit message) or fixup
(to ignore the commit message for that commit). That will combine the squashed/fixed-up commit with the commit immediately before it (or series of commits, if you squash multiple successive commits) If you e.g. have a commit that adds a temp file, and you squash it with a commit that removes it, the resulting commit should be free of the temp file. After you finish making the selections you will get prompted to update the commit messages for the new squashed commits.
Alternatively, you can squash all the commits into one, by running (I think) git reset --soft master; git add -u; git commit
which is equivalent to doing the interactive rebase as above and using the squash
keyword for every commit after the first one in the list.
This can apparently also be done using git merge --squash
. (I haven't tried that one.)
If you make a mistake and lose a commit just run git reflog
and you can find the commit refs that you were previously working on and can reset to.
Thanks, that worked well. Anything else you think that should be done before merging?
2 minor things I'm seeing now:
For consistency in the code with other commands, it might nice to rename get_materials
to bb_materials
.
Also, I get a sed error around line 1272 - $temp_materials
is empty, and sed doesn't like //
at the beginning apparently. (The course doesn't have a Course Materials tab, and the command also says that no materials were found after the error, so it's not that bad.)
Neither of these are critical, so I'd say it's good to merge anytime.
Both valid points, changed to bb_materials
, and it should exit if temp_materials
is empty now.
Anything else? Otherwise, I'll merge and close tonight.
On not having a Course Materials tab, this would probably be fixed by expanding get_assignments
, but that's hard because professors can name the tabs whatever they want (I think). Course Materials is probably the default, as it appears to be the most common.
I've opened an issue that may later explore this. #22
I'd say it's ready to merge.
:clap:
:+1: thanks for all the guidance!
Adds the functionality described in issue 9, namely the ability to download files from blackboard directly from the command line.
Also updates the readme to reflect this added capacity.