search

RoccoC / webpack-build-notifier

A Webpack plugin that generates OS notifications for build steps using node-notifier.
MIT License
162 stars 24 forks source link

Property 'onClick' is missing #38

Closed muuvmuuv closed 5 years ago

muuvmuuv commented 5 years ago

Why do I need to handle onClick by myself? In the docs it says "by default" so I guess this should be optional:

Argument of type '{ title: string; }' is not assignable to parameter of type 'WebpackBuildNotifierConfig'.
  Property 'onClick' is missing in type '{ title: string; }' but required in type 'WebpackBuildNotifierConfig'.

see: index.d.ts#L96

RoccoC commented 5 years ago

You are right, onClick should be made optional.

RoccoC commented 5 years ago

Fixed in 0.1.32.