Sounds play when sound is false

RoccoC / webpack-build-notifier

A Webpack plugin that generates OS notifications for build steps using node-notifier.

MIT License

162 stars 24 forks source link

Closed bwoolnough closed 4 years ago

bwoolnough commented 4 years ago

Setting sound to false doesn't prevent sounds from playing. It only works if I set the specific sound options (successSound etc) to false.

I am using macOS 10.15.2 and webpack-build-notifier 2.0.0.

jimblue commented 4 years ago

I can reproduce that bug on latest release too. @RoccoC can you confirm that please ? This bug is really annoying for development ! Tks man :)

RoccoC commented 4 years ago

Whoops, somehow this bug fell off my radar. This one is now fixed in 2.0.1.

jimblue commented 4 years ago

No worries @RoccoC and thank you so much for the quick fix 💯