Does it work in Big Sur?

RoccoC / webpack-build-notifier

A Webpack plugin that generates OS notifications for build steps using node-notifier.

MIT License

162 stars 24 forks source link

Does it work in Big Sur? #59

Open samuelg0rd0n opened 3 years ago

samuelg0rd0n commented 3 years ago

I'm new to this plugin. I installed it, added it to my webpack.config.js but after build nothing happened. I'm aware that Big Sur broke some things. It this one of them? Can someone confirm it's (not) working on Big Sur? Thank you.

RoccoC commented 3 years ago

Unfortunately I'm still running Catalina, so I am unable to confirm whether Big Sur is causing any issues with notifications.

That being said, I did a cursory search of open issues over at node-notifer (which is what webpack-build-notifier uses to create notifications) and didn't find anything related to Big Sur. I did find this issue in the terminal-notifier project that lists a few problems with notifications in Big Sur, but nothing that would indicate that the notifications wouldn't appear at all.

Can you post up the relevant section of your webpack.config?

In the meantime, I can do some digging to see if there's a way we can enable some logging to see where/why the notification is failing.

samuelg0rd0n commented 3 years ago

Well, I just added this as the last item of the plugins array. Something like:

plugins: [
    ....

    new WebpackBuildNotifierPlugin({
        title: "My project",
        logo: path.resolve("./www/images/favicons/favicon-32x32.png"),
    })
]

Basically just as it's presented on the homepage of this Github. I just removed suppressSuccess because I wanted the notifications to appear for successful builds as well.

I don't see any warning or anything in the command line either. Everything seems working besides the missing notification.

RoccoC commented 3 years ago

Well, that looks fine to me.

I still haven't upgraded to Big Sur so am unable to test locally, but I'm wondering if you would mind trying out the node-notifier example on your machine to see whether or not it works? This would help isolate the issue to either this project or node-notifier.

You'd need to checkout node-notifier and then run

npm run example:mac

If the example generates a notification, that could point to a problem in this package.

samuelg0rd0n commented 3 years ago

node-notifier works fine. Notification popped up.

RoccoC commented 3 years ago

@samuelg0rd0n , thanks for checking, I appreciate it.

I've upgraded node-notifier to the latest version in webpack-build-notifier@2.1.1-alpha. Would you mind giving this version a go to see if it fixes the problem for you? Thanks!

samuelg0rd0n commented 3 years ago

Sorry for the delay in response. I tried upgrading but it didn't help.

RoccoC commented 3 years ago

This was inadvertently closed; re-opening.

RoccoC commented 3 years ago

Sorry for the delay in response. I tried upgrading but it didn't help.

I just upgraded to node-notifier@9.0.0 in the latest release (2.1.1), although it doesn't seem that this will fix the issue you are seeing. Strange that the node-notifier examples are working for you in Big Sur, but this package is not.

What version of webpack are you using?

samuelg0rd0n commented 3 years ago

webpack 4.42.1 and webpack-cli 3.3.11

fregante commented 3 years ago

It's working for me, but I only see the regular terminal icon, not the status ones shown in the readme:

Big Sur 11.4 Node v14.17.0 terminal-notifier 2.0.0 webpack 5.38.1 webpack-cli 4.6.0 webpack-build-notifier 2.2.1

My guess is that macOS no longer allows customizing the app icon so this can only be set as an "attachment image"

meduzen commented 3 years ago

Landing here coincidentally.

I never had trouble having icons on Big Sur (right now I’m on macOS 11.5.2). See this config file.